forked from MarquezProject/marquez
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DGD-4747] Polish the loading feedback #28
Open
Kess220
wants to merge
11
commits into
main
Choose a base branch
from
loading-feedback
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrosend
previously approved these changes
Feb 28, 2025
…edis (#17) * Implementing no-user alert metric and a 7-day cache store in redis
* Adding redis vars to environment
* adding read-only replacements for marquez api * removing init tags from read-only
jonathanpmoraes
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to improve the loading state management and streamline the fetching process for column and table lineage data. The most important changes include adding loading indicators, refactoring the fetching functions, and updating the Redux state management to handle loading states.
Loading State Management:
web/src/routes/column-level/ActionBar.tsx
: Replacedloading
state withisLoading
prop and removed unnecessary state management. [1] [2] [3] [4]web/src/routes/table-level/ActionBar.tsx
: AddedisLoading
prop and updated the loading condition to includeisLoading
. [1] [2] [3]web/src/routes/column-level/ColumnLevel.tsx
: AddedisLoading
prop and conditional rendering for loading state. [1] [2] [3] [4] [5] [6]web/src/routes/table-level/TableLevel.tsx
: AddedisLoading
prop and conditional rendering for loading state. [1] [2] [3] [4] [5] [6] [7]Fetching Functions Refactoring:
web/src/store/actionCreators/index.ts
: AddedfetchLineageStart
andfetchLineageEnd
actions to manage loading state during lineage fetching. [1] [2]web/src/store/actionCreators/actionTypes.ts
: Added new action types for starting and ending the fetching process. [1] [2]Redux State Management:
web/src/store/reducers/columnLineage.ts
: Updated reducer to handleFETCH_COLUMN_LINEAGE_START
andFETCH_COLUMN_LINEAGE_END
actions. [1] [2]web/src/store/reducers/lineage.ts
: Updated reducer to handleFETCH_LINEAGE_START
andFETCH_LINEAGE_END
actions. [1] [2] [3]web/src/store/reducers/index.ts
: Corrected import path forIColumnLineageState
.These changes ensure that the application properly manages loading states, providing a better user experience by displaying loading indicators during data fetching operations.
Type of Change
Checklist