Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DGD-4747] Polish the loading feedback #28

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Conversation

Kess220
Copy link

@Kess220 Kess220 commented Feb 28, 2025

This pull request includes changes to improve the loading state management and streamline the fetching process for column and table lineage data. The most important changes include adding loading indicators, refactoring the fetching functions, and updating the Redux state management to handle loading states.

Loading State Management:

Fetching Functions Refactoring:

Redux State Management:

These changes ensure that the application properly manages loading states, providing a better user experience by displaying loading indicators during data fetching operations.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

jrosend
jrosend previously approved these changes Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants