forked from MarquezProject/marquez
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kafka connector #24
Closed
Closed
Kafka connector #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several significant changes, including the addition of new modules and enhancements to existing functionality. The key changes involve the integration of Kafka for logging, improvements to metrics tracking, and the addition of various helper modules to streamline the codebase.
Integration of Kafka for Logging:
kafkajs
dependency toweb/package.json
andweb/package-lock.json
for Kafka integration. [1] [2] [3]web/services/kafkaProducer.js
to manage Kafka connection and send log messages.Enhancements to Metrics Tracking:
web/services/appMetrics.js
to include detailed comments, integrate with Kafka, and improve email validation and encoding. [1] [2] [3] [4]web/setupProxy.js
to initialize Kafka producer, use new helper modules, and refine user info logging. [1] [2]Addition of Helper Modules:
web/services/helpers/dateTimeHelper.js
for standardized date and time formatting.web/services/helpers/excludedEmails.js
to centralize the list of excluded emails.web/services/helpers/logFormatter.js
to build enriched log data from user info.Documentation and Code Comments:
web/src/auth/AuthContext.tsx
,web/src/components/ErrorBoundary.tsx
,web/src/components/GAInitializer.tsx
,web/src/components/Login.tsx
,web/src/components/LoginCallback.tsx
,web/src/components/PrivateRoute.tsx
, andweb/src/components/ga4.tsx
, to explain the purpose and functionality of each module. [1] [2] [3] [4] [5] [6] [7]These changes collectively enhance the application's logging, metrics tracking, and overall maintainability.
Checklist