search-bar-default

nubank · Feb 28, 2025 · d2a9749 · d2a9749
1 parent d2deeef
commit d2a9749
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 10 deletions.
diff --git a/web/src/components/search/Search.tsx b/web/src/components/search/Search.tsx
@@ -79,6 +79,7 @@ const Search: React.FC<SearchProps> = ({ isLoading, onSearch }) => {
   useEffect(() => {
     // close search on a route change
     setOpen(false)
+    setSearch('')
   }, [location])
 
   const handleSearch = () => {
@@ -93,6 +94,7 @@ const Search: React.FC<SearchProps> = ({ isLoading, onSearch }) => {
 
   const handleClose = () => {
     setOpen(false)
+    setSearch('')
     trackEvent('Search', 'Close Search Bar')
   }
 
@@ -161,7 +163,7 @@ const Search: React.FC<SearchProps> = ({ isLoading, onSearch }) => {
             }
           }}
           value={search}
-          autoComplete={'on'}
+          autoComplete={'off'}
           id={'searchBar'}
         />
         <ClickAwayListener
@@ -198,12 +200,7 @@ const Search: React.FC<SearchProps> = ({ isLoading, onSearch }) => {
                   {process.env.REACT_APP_ADVANCED_SEARCH === 'true' ? (
                     <OpenSearch search={search} />
                   ) : (
-                    <BaseSearch
-                      search={search}
-                      onSuggestionSelect={(selectedName: string) => {
-                        setSearch(selectedName)
-                      }}
-                    />
+                    <BaseSearch search={search} />
                   )}
                 </Box>
               </Box>

diff --git a/web/src/components/search/base-search/BaseSearch.tsx b/web/src/components/search/base-search/BaseSearch.tsx
@@ -19,7 +19,6 @@ import SearchListItem from '../SearchListItem'
 
 interface BaseSearchProps {
   search: string
-  onSuggestionSelect?: (name: string) => void
 }
 
 interface StateProps {
@@ -79,7 +78,6 @@ const BaseSearch: React.FC<BaseSearchProps & StateProps & DispatchProps> = ({
   isSearching,
   fetchSearch,
   setSelectedNode,
-  onSuggestionSelect,
 }) => {
   const [filter, setFilter] = useState('All')
   const [sort, setSort] = useState('UPDATE_AT')
@@ -193,7 +191,6 @@ const BaseSearch: React.FC<BaseSearchProps & StateProps & DispatchProps> = ({
                           search={search}
                           onClick={() => {
                             setSelectedNode(listItem.nodeId)
-                            onSuggestionSelect?.(listItem.name)
                           }}
                         />
                       </React.Fragment>