Skip to content

Allow to set Transfer format (#62) #450

Allow to set Transfer format (#62)

Allow to set Transfer format (#62) #450

GitHub Actions / clippy succeeded Jan 8, 2025 in 0s

clippy

4 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 4
Note 0
Help 0

Versions

  • rustc 1.86.0-nightly (ad211ced8 2025-01-07)
  • cargo 1.86.0-nightly (fd784878c 2025-01-03)
  • clippy 0.1.85 (ad211ced81 2025-01-07)

Annotations

Check warning on line 394 in src/dispatcher.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'f

warning: the following explicit lifetimes could be elided: 'f
   --> src/dispatcher.rs:394:6
    |
394 | impl<'f, F, E> Future for ServiceResult<'f, F, E>
    |      ^^                                 ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
    = note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
    |
394 - impl<'f, F, E> Future for ServiceResult<'f, F, E>
394 + impl<F, E> Future for ServiceResult<'_, F, E>
    |

Check warning on line 176 in src/client/connector.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless conversion to the same type: `client::error::ConnectError`

warning: useless conversion to the same type: `client::error::ConnectError`
   --> src/client/connector.rs:176:27
    |
176 |             Ok(res) => res.map_err(From::from),
    |                           ^^^^^^^^^^^^^^^^^^^^ help: consider removing
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

Check warning on line 145 in src/client/connector.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless conversion to the same type: `client::error::ConnectError`

warning: useless conversion to the same type: `client::error::ConnectError`
   --> src/client/connector.rs:145:27
    |
145 |             Ok(res) => res.map_err(From::from),
    |                           ^^^^^^^^^^^^^^^^^^^^ help: consider removing
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
    = note: `#[warn(clippy::useless_conversion)]` on by default

Check warning on line 152 in src/dispatcher.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this `if` statement can be collapsed

warning: this `if` statement can be collapsed
   --> src/dispatcher.rs:142:9
    |
142 | /         if self.idle_timeout.non_zero() {
143 | |             if self.idle_sleep.poll_elapsed(cx).is_ready() {
144 | |                 log::trace!(
145 | |                     "{}: Send keep-alive ping, timeout: {:?} secs",
...   |
152 | |         }
    | |_________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
    = note: `#[warn(clippy::collapsible_if)]` on by default
help: collapse nested if block
    |
142 ~         if self.idle_timeout.non_zero() && self.idle_sleep.poll_elapsed(cx).is_ready() {
143 +             log::trace!(
144 +                 "{}: Send keep-alive ping, timeout: {:?} secs",
145 +                 self.sink.tag(),
146 +                 self.idle_timeout
147 +             );
148 +             self.sink.post_frame(AmqpFrame::new(0, Frame::Empty));
149 +             self.idle_sleep.reset(self.idle_timeout);
150 +         }
    |