Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(react-native): use native fetch for isPackagerRunning check and remove node-fetch dependency #29568

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Phillip9587
Copy link
Contributor

Removes the node-fetch dependency and uses the native fetch global for the isPackagerRunning() check

Current Behavior

  • Dependency node-fetch is used.

Expected Behavior

  • Removed the node-fetch dependency.
  • Used the native fetch global.

Related Issue(s)

Fixes #

…nd remove `node-fetch` dependency

Removes the `node-fetch` dependency and uses the native fetch global for the `isPackagerRunning()`
check
@Phillip9587 Phillip9587 requested review from a team as code owners January 9, 2025 16:03
Copy link

vercel bot commented Jan 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Jan 9, 2025 4:17pm

Copy link

nx-cloud bot commented Jan 9, 2025

View your CI Pipeline Execution ↗ for commit c5f9bec.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 34m 58s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 1m 10s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base=325b9... ✅ Succeeded 24s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 22s View ↗
nx documentation --no-dte ✅ Succeeded 43s View ↗
nx affected -t e2e-macos-local --parallel=1 --b... ✅ Succeeded 22m 55s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-09 16:47:32 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant