fix(core): update nx cloud bundle install directory logic #29555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit 97ee5cd.
☁️ Nx Cloud last updated this comment at |
Cammisuli
force-pushed
the
feature/nxc-1298-nx-cloud-package-errors-on-v203
branch
from
82ea68c to
249e609
Compare
Cammisuli
force-pushed
the
feature/nxc-1298-nx-cloud-package-errors-on-v203
branch
from
249e609 to
97ee5cd
Compare
FrozenPandaz
approved these changes
Jan 8, 2025
jaysoo
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Whenever the
nx-cloudpackage is installed in a workspace, we get errors about certain properties not being instantiated.This happens because the old
nx-cloudpackage placed the nx cloud bundle innode_modules/.cache/nx/cloud.Nx will then eventually try to use the cloud bundle, and not look into the
node_modules/.cache/nx/clouddirectory, and instead look into.nx/cache/cloud. Because the bundle doesnt exist in the.nx/cache/cloudlocation, we will redownload the bundle, and not properly instantiate it.Expected Behavior
Nx will now look into the legacy location in
node_modules/.cache/nx/cloudwhen trying to get the cloud bundle.Related Issue(s)
Fixes #