fix(js): avoid nested paths in workspaces because they can lead to future issues #29553
+37
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaysoo
requested review from
a team,
FrozenPandaz,
vsavkin,
AgentEnder and
JamesHenry
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit 2653680.
☁️ Nx Cloud last updated this comment at |
Coly010
approved these changes
Jan 8, 2025
jaysoo
force-pushed
the
fix/workspaces-glob
branch
2 times, most recently
from
f8ad3fb to
107179a
Compare
jaysoo
force-pushed
the
fix/workspaces-glob
branch
from
107179a to
2653680
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the new TS setup, we currently use nested glob patterns:
apps/**,libs/**, andpackages/**.Nested paths can result into too many projects being matched. For example, if
libs/mylib/src/__fixtures__/package.jsonis there for testing, it will be matched as a project and likely result in an error.Other tools like turborepo also caution against this: https://turbo.build/repo/docs/crafting-your-repository/structuring-a-repository#declaring-directories-for-packages
If users want to, they could change to nested
**paths, but we should not use it by default.Note: For CNW, we only use
apps/*by default since that is where the project lives. When users donx g lib packages/foothenpackages/*will be added automatically.Current Behavior
Use nested
**paths.Expected Behavior
Don't use nested
**paths.Related Issue(s)
Fixes #