fix(core): avoid launching default plugins twice #29539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
View your CI Pipeline Execution ↗ for commit a5b786e.
☁️ Nx Cloud last updated this comment at |
AgentEnder
force-pushed
the
fix/only-launch-default-plugins-once
branch
from
1ac8357 to
e216afc
Compare
AgentEnder
force-pushed
the
fix/only-launch-default-plugins-once
branch
from
1bde73f to
3d23c4c
Compare
AgentEnder
force-pushed
the
fix/only-launch-default-plugins-once
branch
from
3d23c4c to
824fc92
Compare
FrozenPandaz
approved these changes
Jan 8, 2025
Comment on lines
276
to
279
| async function normalizePlugins(plugins: PluginConfiguration[], root: string) { | ||
| plugins ??= []; | ||
|
|
||
| return [ | ||
| ...plugins, | ||
| // Most of the nx core node plugins go on the end, s.t. it overwrites any other plugins | ||
| ...(await getDefaultPlugins(root)), | ||
| ]; | ||
| return [...plugins]; |
There was a problem hiding this comment.
I believe we don't have to normalize plugins at all anymore?
| * Use `getPlugins` instead. | ||
| * @deprecated Do not use this. Use `getPlugins` instead. | ||
| */ | ||
| export async function loadNxPlugins( |
There was a problem hiding this comment.
This is now only used in 2 tests. Can we get rid of this function?
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Default plugins are launched twice when loading plugins in a workspace that has local plugins:
Expected Behavior
Default plugins are launched once and reused
Related Issue(s)
Fixes #