docs(nx-cloud): use assignment rules with self provisioned agents #29490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lourw
requested review from
StalkAltan,
rarmatei,
nixallover and
a team
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lourw
changed the title
|
View your CI Pipeline Execution ↗ for commit 9bc0cfa.
☁️ Nx Cloud last updated this comment at |
lourw
force-pushed
the
lourw/assignment-rules-manual-dte
branch
from
e71188d to
32da153
Compare
lourw
force-pushed
the
lourw/assignment-rules-manual-dte
branch
from
32da153 to
aae1cf2
Compare
isaacplmann
approved these changes
Jan 7, 2025
lourw
force-pushed
the
lourw/assignment-rules-manual-dte
branch
from
12b9031 to
89afb18
Compare
lourw
force-pushed
the
lourw/assignment-rules-manual-dte
branch
from
89afb18 to
eda7547
Compare
lourw
force-pushed
the
lourw/assignment-rules-manual-dte
branch
from
eda7547 to
66e357b
Compare
|
@isaacplmann I added some more details and edited some of the grammar. Can I just get one more once-over from you? |
isaacplmann
reviewed
Jan 16, 2025
Comment on lines
29
to
30
| {% callout type="note" title="If you are using self-hosted agents, you must define your own agent types" %} | ||
| You can define your own agent types and attach them to your self-hosted agents using the `NX_AGENT_LAUNCH_TEMPLATE` environment variable. Ensure that for each `runs-on` field in your assignment rules, you have corresponding agents in your agent pool that have the same agent type. |
There was a problem hiding this comment.
Is it "you must" or "you can"? One of these needs to be changed
isaacplmann
approved these changes
Jan 16, 2025
FrozenPandaz
pushed a commit
that referenced
this pull request
Jan 17, 2025
…9490) <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> The initial version of the docs only allow the use of assignment rules with Nx Agents. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> The updated docs include an overview and example of how to configure assignment rules to work with self provisioned agents (and DTE in 'manual' mode). ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes # --------- Co-authored-by: Isaac Mann <[email protected]> (cherry picked from commit bb03ed7)
FrozenPandaz
pushed a commit
that referenced
this pull request
Jan 22, 2025
…9490) <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> The initial version of the docs only allow the use of assignment rules with Nx Agents. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> The updated docs include an overview and example of how to configure assignment rules to work with self provisioned agents (and DTE in 'manual' mode). ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes # --------- Co-authored-by: Isaac Mann <[email protected]> (cherry picked from commit bb03ed7)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
The initial version of the docs only allow the use of assignment rules with Nx Agents.
Expected Behavior
The updated docs include an overview and example of how to configure assignment rules to work with self provisioned agents (and DTE in 'manual' mode).
Related Issue(s)
Fixes #