-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(testing): add option ciGroupName
to @nx/jest/plugin
#29365
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
View your CI Pipeline Execution ↗ for commit 1f37a09.
☁️ Nx Cloud last updated this comment at |
ab0b5f3
to
367b046
Compare
Your CI Pipeline Execution ↗ for commit 86384d3 is in progress ⏳
☁️ Nx Cloud last updated this comment at |
367b046
to
df1d130
Compare
df1d130
to
86384d3
Compare
86384d3
to
b501652
Compare
b501652
to
73d9507
Compare
73d9507
to
a778f68
Compare
a778f68
to
0304d8f
Compare
0304d8f
to
829fe50
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
I left a couple of things to address, but it looks good overall. This is a good change.
ciGroupName
to allow customizing the name of…ciGroupName
to @nx/jest/plugin
4dab65f
to
5b7aab7
Compare
5b7aab7
to
d74f4a4
Compare
d74f4a4
to
185c4cc
Compare
… of `Jest` atomized taks group on CI Closes nrwl#28066 Co-authored-by: Leosvel Pérez Espinosa <[email protected]>
185c4cc
to
1f37a09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Add option
ciGroupName
to the@nx/jest/plugin
to allow customizing theJest
atomized taks group on CI.Current Behavior
When using Atomizer on Jest for unit tests (via the
"ciTargetName": "test-ci"
), the atomized tasks will be grouped under the misleading name "E2E (CI)".Worst, if Atomizer is enabled for both unit and e2e tests, it will result on E2E atomized tasks being overwritten by the one from unit tests... when run on Nx Cloud.
Expected Behavior
Allow customizing the name of the atomized tasks group. The group name can be derived from the
ciTargetName
, when not explicitly provided.Related Issue(s)
Fixes #28066