Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(testing): add option ciGroupName to @nx/jest/plugin #29365

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

tinesoft
Copy link
Contributor

@tinesoft tinesoft commented Dec 16, 2024

Add option ciGroupName to the @nx/jest/plugin to allow customizing the Jest atomized taks group on CI.

Current Behavior

When using Atomizer on Jest for unit tests (via the "ciTargetName": "test-ci"), the atomized tasks will be grouped under the misleading name "E2E (CI)".

Worst, if Atomizer is enabled for both unit and e2e tests, it will result on E2E atomized tasks being overwritten by the one from unit tests... when run on Nx Cloud.

Expected Behavior

Allow customizing the name of the atomized tasks group. The group name can be derived from the ciTargetName , when not explicitly provided.

Related Issue(s)

Fixes #28066

@tinesoft tinesoft requested review from a team as code owners December 16, 2024 11:38
Copy link

vercel bot commented Dec 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Jan 9, 2025 5:28am

Copy link

nx-cloud bot commented Dec 16, 2024

View your CI Pipeline Execution ↗ for commit 1f37a09.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 35m View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 1m 10s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 1s View ↗
nx-cloud record -- nx format:check --base=0edd1... ✅ Succeeded 18s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 16s View ↗
nx documentation --no-dte ✅ Succeeded 40s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-09 06:15:09 UTC

Copy link

nx-cloud bot commented Dec 17, 2024

Your CI Pipeline Execution ↗ for commit 86384d3 is in progress ⏳

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 37m 41s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 1m 5s View ↗
nx-cloud record -- nx format:check --base=fb403... ✅ Succeeded 21s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded <1s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 20s View ↗
nx documentation --no-dte ✅ Succeeded 43s View ↗

☁️ Nx Cloud last updated this comment at 2024-12-18 09:41:59 UTC

Copy link
Member

@leosvelperez leosvelperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I left a couple of things to address, but it looks good overall. This is a good change.

docs/shared/packages/jest/jest-plugin.md Outdated Show resolved Hide resolved
docs/shared/packages/jest/jest-plugin.md Outdated Show resolved Hide resolved
docs/shared/packages/jest/jest-plugin.md Outdated Show resolved Hide resolved
packages/jest/src/plugins/plugin.ts Outdated Show resolved Hide resolved
docs/shared/packages/jest/jest-plugin.md Outdated Show resolved Hide resolved
@leosvelperez leosvelperez changed the title feat(core): add option ciGroupName to allow customizing the name of… feat(testing): add option ciGroupName to @nx/jest/plugin Jan 8, 2025
@tinesoft tinesoft force-pushed the feat/jest-atomizer branch from 4dab65f to 5b7aab7 Compare January 8, 2025 19:54
… of `Jest` atomized taks group on CI

Closes nrwl#28066

Co-authored-by: Leosvel Pérez Espinosa <[email protected]>
Copy link
Member

@leosvelperez leosvelperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@leosvelperez leosvelperez merged commit addf107 into nrwl:master Jan 9, 2025
6 checks passed
@tinesoft tinesoft deleted the feat/jest-atomizer branch January 9, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Atomized groups have always suffix E2E (CI). This should be toggleable
2 participants