fix(nextjs): ensure next 14 is installed if react 18

nrwl · Jan 9, 2025 · 735af1e · 735af1e
1 parent ee443c6
commit 735af1e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/packages/next/src/generators/init/init.ts b/packages/next/src/generators/init/init.ts
@@ -8,7 +8,10 @@ import {
   createProjectGraphAsync,
 } from '@nx/devkit';
 import { addPlugin } from '@nx/devkit/src/utils/add-plugin';
-import { getReactDependenciesVersionsToInstall } from '@nx/react/src/utils/version-utils';
+import {
+  getReactDependenciesVersionsToInstall,
+  isReact18,
+} from '@nx/react/src/utils/version-utils';
 import { addGitIgnoreEntry } from '../../utils/add-gitignore-entry';
 import { nxVersion } from '../../utils/versions';
 import { getNextDependenciesVersionsToInstall } from '../../utils/version-utils';
@@ -19,7 +22,10 @@ async function updateDependencies(host: Tree, schema: InitSchema) {
 
   tasks.push(removeDependenciesFromPackageJson(host, ['@nx/next'], []));
 
-  const versions = await getNextDependenciesVersionsToInstall(host);
+  const versions = await getNextDependenciesVersionsToInstall(
+    host,
+    await isReact18(host)
+  );
   const reactVersions = await getReactDependenciesVersionsToInstall(host);
 
   tasks.push(

diff --git a/packages/next/src/utils/version-utils.ts b/packages/next/src/utils/version-utils.ts
@@ -7,7 +7,8 @@ type NextDependenciesVersions = {
 };
 
 export async function getNextDependenciesVersionsToInstall(
-  tree: Tree
+  tree: Tree,
+  isReact18 = false
 ): Promise<NextDependenciesVersions> {
   if (await isNext14(tree)) {
     return {