Skip to content

Commit

Permalink
fix(angular): throw an error when providing --serverRouting in setu…
Browse files Browse the repository at this point in the history
…p-ssr generator for webpack executors (#29614)

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
  • Loading branch information
leosvelperez committed Jan 16, 2025
1 parent 386d81d commit 0019421
Showing 1 changed file with 7 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,13 @@ export async function normalizeOptions(
} else {
options.serverRouting = false;
}
} else if (
options.serverRouting !== undefined &&
!isUsingApplicationBuilder
) {
throw new Error(
'Server routing APIs can only be added to a project using `application` builder.'
);
}

const isStandaloneApp = isNgStandaloneApp(tree, options.project);
Expand Down

0 comments on commit 0019421

Please sign in to comment.