nrf_wifi: Provide PCB loss information from RF params #1351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kspraveeen
requested review from
udaynordic,
rajb9,
srkanordic,
krish2718,
sachinthegreen,
rado17 and
rlubos
as code owners
srkanordic
reviewed
Jun 3, 2024
srkanordic
approved these changes
Jun 3, 2024
krish2718
requested changes
Jun 3, 2024
| @@ -39,7 +39,8 @@ enum nrf_wifi_status umac_cmd_init(struct nrf_wifi_fmac_dev_ctx *fmac_dev_ctx, | |||
| unsigned int phy_calib, | |||
| enum op_band op_band, | |||
| bool beamforming, | |||
| struct nrf_wifi_tx_pwr_ctrl_params *tx_pwr_ctrl_params); | |||
| struct nrf_wifi_tx_pwr_ctrl_params *tx_pwr_ctrl_params, | |||
| struct nrf_wifi_board_params *pcb_loss_info); | |||
There was a problem hiding this comment.
use either pcb or board a consistent term.
| PCB_LOSS_BYTE_5G_BAND1_OFST, | ||
| PCB_LOSS_BYTE_5G_BAND2_OFST, | ||
| PCB_LOSS_BYTE_5G_BAND3_OFST, | ||
| NUM_PCB_LOSS_OFFSET = 4 |
There was a problem hiding this comment.
This looks odd, is it really an offset? if yes, please add a comment, if not please move out of the enum
There was a problem hiding this comment.
These are offsets(185,186,187,188) indexed to access RF parameters, except the last one.
There was a problem hiding this comment.
Yes, my query was for the last one. So, it should be moved out of Enum.
FYI, even when you select a line and comment against that line, GH shows other lines for context, but the comment is applicable only for the last line.
There was a problem hiding this comment.
Moved the last parameter out of the enum.
sachinthegreen
requested changes
Jun 3, 2024
kspraveeen
force-pushed
the
shel_2800
branch
3 times, most recently
from
701332b to
4f034e3
Compare
krish2718
approved these changes
Jun 3, 2024
sachinthegreen
approved these changes
Jun 4, 2024
[SHEL-2800]: Support for considering band dependent PCB loss in PHY firmware. Signed-off-by: Praveen Kankipati <[email protected]> Signed-off-by: Mahammadyunus Patil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SHEL-2800: Support for considering band dependent PCB loss in PHY firmware.
adding manifest-pr-skip