Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 455 admin netpols test coverage #494

Merged
merged 8 commits into from
Jan 29, 2025

Conversation

shireenf-ibm
Copy link
Contributor

@shireenf-ibm shireenf-ibm commented Jan 28, 2025

#455

  • the only err paths that are not tested as bad-paths, are the errors returned from funcs related to eval command (i.e. bad-path tests for eval)

  • commits are explained, each contains one "item"

Copy link
Collaborator

@adisos adisos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!
added few small comments.

pkg/netpol/internal/common/connectionset.go Outdated Show resolved Hide resolved
pkg/netpol/eval/resources.go Show resolved Hide resolved
@adisos adisos linked an issue Jan 29, 2025 that may be closed by this pull request
@shireenf-ibm shireenf-ibm requested a review from adisos January 29, 2025 11:31
@shireenf-ibm shireenf-ibm merged commit 47c85d2 into main Jan 29, 2025
4 checks passed
@shireenf-ibm shireenf-ibm deleted the issue_455_admin_netpols_test_coverage branch January 29, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ANPs] admin-netpols tests coverage
2 participants