Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diff dot ns frames #283

Merged
merged 19 commits into from
Dec 18, 2023
Merged

Diff dot ns frames #283

merged 19 commits into from
Dec 18, 2023

Conversation

shireenf-ibm
Copy link
Contributor

@shireenf-ibm shireenf-ibm commented Dec 7, 2023 •
edited
Loading

issue #279

@shireenf-ibm shireenf-ibm linked an issue Dec 7, 2023 that may be closed by this pull request
Improve connectivity visualization graphs #279
Closed
2 tasks
@shireenf-ibm shireenf-ibm requested a review from adisos December 7, 2023 14:55
@shireenf-ibm
doc update
da563e0
@shireenf-ibm
fix - peer nodes should have the peer.String() (i.e. full name), elim…
3c94246 
…inating the namespace only from the label displayed on the graph.

to avoid wrong edges if different namespaces have peers with similar names
@shireenf-ibm
fixing the doc dot outputs
4d5ad75
adisos
adisos requested changes Dec 10, 2023
View reviewed changes
docs/diff_output.md Outdated Show resolved Hide resolved
docs/diff_output.md Outdated Show resolved Hide resolved
pkg/netpol/internal/common/netpol_commands_common.go Outdated Show resolved Hide resolved
@shireenf-ibm shireenf-ibm requested a review from adisos December 10, 2023 08:55
adisos
adisos reviewed Dec 18, 2023
View reviewed changes
Copy link
Collaborator

@adisos adisos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do the ci tests fail now?

@shireenf-ibm
Copy link
Contributor Author

why do the ci tests fail now?

in this branch I made minor changes to dot output (peers node name ) in both connlist and diff.
I need to run test-update for the new dot output that was added by the "connlist doc update branch" to get the fixed ones for this branch.

adisos
adisos reviewed Dec 18, 2023
View reviewed changes
docs/diff_output.md Outdated Show resolved Hide resolved
@shireenf-ibm shireenf-ibm merged commit 5d82e99 into main Dec 18, 2023
4 checks passed
@shireenf-ibm shireenf-ibm deleted the diff_dot_ns_frames branch December 18, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisos adisos adisos approved these changes

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve connectivity visualization graphs
2 participants
@shireenf-ibm @adisos