-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 110 tests improvements connlist pkg #250
Merged
shireenf-ibm
merged 15 commits into
main
from
issue_110_tests_improvements_connlist_pkg
Oct 22, 2023
Merged
Issue 110 tests improvements connlist pkg #250
shireenf-ibm
merged 15 commits into
main
from
issue_110_tests_improvements_connlist_pkg
Oct 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adisos
reviewed
Oct 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good!
Added a few comments.
As for generating/overriding expected output files -- please consider we also need to be able to run this locally, not necessarily in a workflow. |
adisos
reviewed
Oct 19, 2023
adisos
reviewed
Oct 22, 2023
Co-authored-by: Adi Sosnovich <[email protected]>
Co-authored-by: Adi Sosnovich <[email protected]>
Co-authored-by: Adi Sosnovich <[email protected]>
adisos
reviewed
Oct 22, 2023
adisos
reviewed
Oct 22, 2023
adisos
reviewed
Oct 22, 2023
adisos
reviewed
Oct 22, 2023
this commit |
adisos
approved these changes
Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #110
this PR , includes tests improvements to
connlist_test.go
fileall test
funcs
run in parallel, and for eachtest func, all cases run in parallel too.
tried to split
TestXXX
funcs by "testing cases" to avoidif else
conditions in the test functionalitythis PR does not handle generating/overriding expected output files (prefer to keep it for a separate PR, want to study if it is possible to write a workflow that could be run by
go test --override
(for example))