Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Updates submodule hyrax-webapp #225

Merged
merged 2 commits into from
Feb 4, 2025
Merged

Conversation

sjproctor
Copy link
Contributor

Story: [i142] Home Page Themes

Ref:

Expected Behavior Before Changes

Reported UI oddities and bugs on the home pages of all four (4) themes in Hyku

  • Headers and Footer not responsive
  • Neutral theme body content not responsive
  • Featured works cards misaligned with featured collections cards on logged out view

Expected Behavior After Changes

  • Responsive headers and footers in all four (4) themes
  • Neutral theme body content adapts to smaller screen sizes, no horizontal scroll
  • Featured works cards are the same size as featured collections cards on logged out view

Screenshots / Video

Default theme: header + footer

image

Cultural theme: header + footer

image

Institutional theme: header + footer

image

Neutral theme: body content adapts to smaller screen sizes, no horizontal scroll + responsive header and footer

image

Featured works cards are the same size as featured collections cards on logged out view

image

The cancancan gem was bundling at v1.17.0 which was causing CI to fail.
This commit updates the gem to v3 or later.

Ref:
- #142
@sjproctor sjproctor merged commit 9aec142 into main Feb 4, 2025
6 checks passed
@sjproctor sjproctor deleted the i142-home-page-themes branch February 4, 2025 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants