Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not order location attribute #989

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Do not order location attribute #989

merged 1 commit into from
Mar 8, 2024

Conversation

laritakr
Copy link
Contributor

@laritakr laritakr commented Mar 8, 2024

Story

Ordering based_near causes several issues:

  • adding a work to a collection fails
  • adding a work outside of the actor stack turned the attribute into a string.

Refs:

Expected Behavior Before Changes

Adding a work with a location value to a collection fails.

Expected Behavior After Changes

Adding a work with a location value to a collection succeeds
The location term is not ordered.

Notes

Ordering based_near causes several issues:
- adding a work to a collection fails
- adding a work outside of the actor stack turned the attribute into a string.

Refs:
- #892
- #964
@laritakr laritakr merged commit 687d982 into main Mar 8, 2024
7 checks passed
@laritakr laritakr deleted the i892-location branch March 8, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants