🐛 Fix audio mime type for IIIF manifest #935
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
This commit will use
audio/mpeg
as the mime type for mp3 resources in the IIIF manifest instead of relying on the characterized mime type of the original file. This is a problem when our file is a wav file and it gets characterized asaudio/x-wave
which doesn't work with Universal Viewer. Instead, since we are serving up the mp3 derivative in the manifest, we should useaudio/mpeg
as the mime type. We also remove the ogg format because it is not being used and having that hard coded asaudio/mpeg
as well feels incorrect. This however doesn't solve the bigger problem of the File Set not gettig the original file in the first place but that is a separate issue and would need some investigation.Ref:
Screenshots / Video
Manifest: