Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎁 I911 video embed for themes #930

Merged
merged 3 commits into from
Dec 7, 2023
Merged

Conversation

ShanaLMoore
Copy link
Contributor

@ShanaLMoore ShanaLMoore commented Dec 6, 2023

This PR adds video_embed to the following themes:

Screenshot 2023-12-06 at 2 06 01 PM

Issue:

Default Show Page

image

Cultural

Screenshot 2023-12-06 at 14-43-15 Where Each Stone Is History Travel Guides in Sevastopol after World War II

Scholarly

Screenshot 2023-12-06 at 14-48-31 Where Each Stone Is History Travel Guides in Sevastopol after World War II

Reshare

image

Shana Moore added 2 commits December 6, 2023 13:40
This commit updates the scholarly theme's show page to handle video embed

Issue:
- #911
@ShanaLMoore ShanaLMoore changed the base branch from main to i911-video-embed-Image December 6, 2023 22:08
@ShanaLMoore ShanaLMoore marked this pull request as draft December 6, 2023 22:38
@ShanaLMoore ShanaLMoore force-pushed the i911-video-embed-for-themes branch from d0fc820 to 628981c Compare December 6, 2023 22:47
@ShanaLMoore ShanaLMoore marked this pull request as ready for review December 6, 2023 22:50
Base automatically changed from i911-video-embed-Image to main December 7, 2023 14:48
@ShanaLMoore ShanaLMoore merged commit b6f0a7c into main Dec 7, 2023
1 check passed
@ShanaLMoore ShanaLMoore deleted the i911-video-embed-for-themes branch December 7, 2023 14:48
jeremyf added a commit that referenced this pull request Dec 18, 2023
Prior to this commit, we had a case where `<% render` was called.  The
result would be that we would in fact not render the results.

In the [file from PR 930][1] the render moved from `<%= render` to `<%
render`

With this commit, we restore that rendering.

Related to:

- #930
- #911

[1]: https://github.com/scientist-softserv/palni-palci/pull/930/files#diff-521d4c52bd51d0f13962e2d0b09d2740a257187d4fbf7b1fd8cff53e36b1362e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants