🐛 Omit DataType=Platform when provided DataType does not include Platform #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirkkwang
approved these changes
Oct 30, 2023
jeremyf
force-pushed
the
i686-omit-data-type-platform-when-data-type-specified
branch
from
deb01f1 to
8c06db9
Compare
…form Prior to this commit, if the query parameters included only non-platform data_type (e.g. article) then we would continue to show the platform data type node. With this commit, we skip showing that element if we have been provided explicit data_type(s) and none of them are Platform. Related to: - #686 (comment)
jeremyf
force-pushed
the
i686-omit-data-type-platform-when-data-type-specified
branch
from
8c06db9 to
e7372eb
Compare
jeremyf
deleted the
i686-omit-data-type-platform-when-data-type-specified
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, if the query parameters included only non-platform data_type (e.g. article) then we would continue to show the platform data type node.
With this commit, we skip showing that element if we have been provided explicit data_type(s) and none of them are Platform.
Related to: