🎁 Update Bulkrax for Download Cloud Files work #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyf
approved these changes
Feb 22, 2024
This commit will update Bulkrax to from v5.2.1 to v5.3.1 on a special branch to turn the `DownloadCloudFilesJob` from a perform_now to a perform_later. Logging information was added to help monitor the download progress. Ref: - samvera/bulkrax@2ab3ef0
kirkkwang
force-pushed
the
update-bulkrax-for-download-cloud-files
branch
from
aae76e2 to
6be9fe4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
This commit will update Bulkrax to from v5.2.1 to v5.3.1 on a special branch to turn the
DownloadCloudFilesJobfrom a perform_now to a perform_later. Logging information was added to help monitor the download progress.Ref:
Expected Behavior Before Changes
When using Browse Everything to import files, the page would lock up until the download was finished because the
DownloadCloudFilesJobwas doing a#perform_now. This would be particularly problematic for large files that may take a long time to download and eventually time out.Expected Behavior After Changes
When using Browse Everything to import files, the page would redirect immediately because the
DownloadCloudFilesJobis now being run asynchronously as a background job. Rails logging has been added to help devs monitor the download progress.Screenshots / Video
Zight.Recording.2024-02-21.at.09.51.24.mp4