Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add calls to logger in exchange #56

Merged
merged 5 commits into from
Nov 22, 2023
Merged

add calls to logger in exchange #56

merged 5 commits into from
Nov 22, 2023

Conversation

miyaliu627
Copy link
Contributor

called log_event in the match_order function to log the matches and ob_update in MatchResult.

egelja
egelja requested changes Nov 22, 2023
View reviewed changes
Copy link
Member

@egelja egelja left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, but the comments don’t need to be nearly this verbose.

also snake case please

@miyaliu627 miyaliu627 requested a review from egelja November 22, 2023 04:59
egelja
egelja approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@egelja egelja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

pls squash

@egelja egelja changed the title added calls to logger in exchange add calls to logger in exchange Nov 22, 2023
egelja
egelja requested changes Nov 22, 2023
View reviewed changes
Copy link
Member

@egelja egelja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually wait actions failing

@miyaliu627 miyaliu627 requested a review from egelja November 22, 2023 17:33
@egelja
Copy link
Member

egelja commented Nov 22, 2023

it built i'm merging it

@egelja egelja merged commit 1509d53 into main Nov 22, 2023
@egelja egelja deleted the logger-exchange branch November 22, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egelja egelja egelja approved these changes

@stevenewald stevenewald Awaiting requested review from stevenewald stevenewald is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miyaliu627 @egelja