fix a code cov issue by removing old code

northwesternfintech · Nov 29, 2023 · 722bd97 · 722bd97
1 parent ea55085
commit 722bd97
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 30 deletions.
diff --git a/wrapper/src/pywrapper/pywrapper.cpp b/wrapper/src/pywrapper/pywrapper.cpp
@@ -33,19 +33,6 @@ get_trade_and_account_update_function()
     return py::globals()["strategy"].attr("on_trade_and_account_update");
 }
 
-// A tiny amount of backwards compatibility
-const py::object
-get_trade_update_function()
-{
-    return py::globals()["strategy"].attr("on_trade_and_account_update");
-}
-
-const py::object
-get_account_update_function()
-{
-    return py::globals()["strategy"].attr("on_trade_and_account_update");
-}
-
 void
 run_code_init(const std::string& py_code)
 {

diff --git a/wrapper/src/pywrapper/pywrapper.hpp b/wrapper/src/pywrapper/pywrapper.hpp
@@ -29,21 +29,7 @@ const py::object get_ob_update_function();
  * Designed to be triggered by the rabbitmq class when a trade or account update is
  * received
  */
-const py::object get_on_trade_and_account_update();
-
-/**
- * @brief Gets the callback function for trade updates
- *
- * Some backwards compatibility, but returns on_trade_and_account_update()
- */
-const py::object get_trade_update_function();
-
-/**
- * @brief Gets the callback function for account updates
- *
- * Some backwards compatibility, but returns on_trade_and_account_update()
- */
-const py::object get_account_update_function();
+const py::object get_trade_and_account_update_function();
 
 /**
  * @brief Creates the Python API module

diff --git a/wrapper/src/rabbitmq/rabbitmq.cpp b/wrapper/src/rabbitmq/rabbitmq.cpp
@@ -100,7 +100,7 @@ RabbitMQ::handleIncomingMessages()
                     Match match = std::get<Match>(data);
                     std::string side =
                         match.side == messages::SIDE::BUY ? "BUY" : "SELL";
-                    nutc::pywrapper::get_trade_update_function()(
+                    nutc::pywrapper::get_trade_and_account_update_function()(
                         match.ticker, side, match.price, match.quantity
                     );
                     return nothing;
@@ -114,7 +114,7 @@ RabbitMQ::handleIncomingMessages()
                     );
                     std::string side =
                         update.side == messages::SIDE::BUY ? "BUY" : "SELL";
-                    nutc::pywrapper::get_account_update_function()(
+                    nutc::pywrapper::get_trade_and_account_update_function()(
                         update.ticker,
                         side,
                         update.price,