-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NSFS | NC | add option to set account supplemental groups #8552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadavMiz
force-pushed
the
suplemental-groups
branch
4 times, most recently
from
November 24, 2024 09:34
702fd42
to
9abd913
Compare
naveenpaul1
reviewed
Dec 4, 2024
romayalon
previously requested changes
Dec 4, 2024
nadavMiz
force-pushed
the
suplemental-groups
branch
11 times, most recently
from
December 11, 2024 16:53
f2ee5e0
to
6f7239b
Compare
shirady
reviewed
Dec 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added my comments (without the native files).
I would list things that you can add in this PR:
- Tests for the noobaa-cli that combines the supplemental groups with the
--from_file
flag. - Tests for the noobaa-cli that combines the supplemental groups with the
--anonymous
flag - Update the
S3Ops.md
about permission - currently only UID, GID is mentioned.
src/test/unit_tests/jest_tests/test_nc_nsfs_account_cli.test.js
Outdated
Show resolved
Hide resolved
src/test/unit_tests/jest_tests/test_nc_nsfs_account_cli.test.js
Outdated
Show resolved
Hide resolved
nadavMiz
force-pushed
the
suplemental-groups
branch
5 times, most recently
from
December 15, 2024 17:51
08a66b9
to
406c2ed
Compare
shirady
reviewed
Dec 16, 2024
shirady
reviewed
Dec 16, 2024
nadavMiz
force-pushed
the
suplemental-groups
branch
from
December 16, 2024 08:00
406c2ed
to
b07ff70
Compare
nadavMiz
force-pushed
the
suplemental-groups
branch
5 times, most recently
from
December 23, 2024 19:36
b948756
to
cbb9118
Compare
nadavMiz
force-pushed
the
suplemental-groups
branch
3 times, most recently
from
January 8, 2025 10:41
3ec6ddd
to
1ef9a41
Compare
nadavMiz
force-pushed
the
suplemental-groups
branch
3 times, most recently
from
January 8, 2025 12:11
0e324bf
to
87ed095
Compare
shirady
reviewed
Jan 8, 2025
nadavMiz
force-pushed
the
suplemental-groups
branch
4 times, most recently
from
January 9, 2025 10:20
500d0e5
to
be3a2b0
Compare
shirady
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: nadav mizrahi <[email protected]>
nadavMiz
force-pushed
the
suplemental-groups
branch
from
January 9, 2025 11:09
be3a2b0
to
fff7900
Compare
This was referenced Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
supplemental groups are additional groups an account can be part of besides his main group (gid). add option to set a users supplemental groups through the nsfs cli. see
Supplementary group IDs
in https://man7.org/linux/man-pages/man7/credentials.7.html. having addition groups allows account to access files and directory that allow access to one of the accounts supplemental groups (similar to main group access ). supplementary group IDs are used mainly for adding permissions. for other purposes the accounts main GID will be used (for example determining the group of a file created by the account). note that this enables access only on file system level, s3 commands will still require bucket policy permissions. in the same manner account will still be block from accessing the file system even if it has bucket policy permissionsnsfs_account_config
Issues: Fixed #7274
Testing Instructions:
sudo npx jest test_nc_nsfs_account_cli.test.js
sudo npx jest test_nc_nsfs_anonymous_cli.test.js
sudo node ./node_modules/mocha/bin/mocha src/test/unit_tests/test_nsfs_access.js
sudo NC_CORETEST=true node ./node_modules/mocha/bin/mocha src/test/unit_tests/test_nsfs_integration.js
Gaps
#8665
noobaa/noobaa-operator#1505