Fix resolving modules with .js in module name #34
Conversation
When using nashorn and loading a script with a dependency to a node module that contains .js in its name e.g. decimal.js, the actual js file couldn't be resolved. The fix is achieved by trying to resolve to directory first and then to file.
|
Hi @conla, can you please provide a test case which fails, and show that this change fixes it? We already have a test for finding a module with an extension here https://github.com/nodyn/jvm-npm/blob/master/src/test/javascript/specs/requireSpec.js#L114-L117. |
There was a problem hiding this comment.
The code here is modeled on the Node.js module resolution algorithm, loosely outlined here: https://nodejs.org/api/modules.html#modules_all_together. I'm not keen on changing this. I would like to see a failing test case, because there may be another way to solve the issue without these modifications.
|
The code change presented here helped me to fix an issue in one of my projects. |
|
Maybe this is a windows-specific issue and has something to do with issue #15. But I'm only guessing. |
When using nashorn and loading a script with a dependency to a node
module that contains .js in its name e.g. decimal.js, the actual js
file inside the module couldn't be resolved.
The fix is achieved by trying to resolve to directory first and then
to file.