Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zlib: make all zstd functions experimental #56964

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

zlib: make all zstd functions experimental #56964

wants to merge 1 commit into from

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Feb 8, 2025 •
edited
Loading

Original PR didn't make these functions experimental. Let's make it, before we know the API surface is stable.

Ref: #52100

cc @jkrems

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. zlib Issues and PRs related to the zlib subsystem. labels Feb 8, 2025
jkrems
jkrems approved these changes Feb 8, 2025
View reviewed changes
Copy link
Contributor

@jkrems jkrems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, good point!

@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 8, 2025
@lpinca
Copy link
Member

lpinca commented Feb 8, 2025

I would replace zlib: with doc: in commit title.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@jkrems jkrems jkrems approved these changes

@lpinca lpinca lpinca approved these changes

@atlowChemi atlowChemi atlowChemi approved these changes

@mcollina mcollina Awaiting requested review from mcollina

@KhafraDev KhafraDev Awaiting requested review from KhafraDev

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. doc Issues and PRs related to the documentations. zlib Issues and PRs related to the zlib subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@anonrig @lpinca @jasnell @jkrems @atlowChemi @nodejs-github-bot