src: improve error handling in multiple files #56962
Open
+212
−180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
anonrig
approved these changes
Feb 8, 2025
| info.GetReturnValue().Set( | ||
| String::NewFromUtf8(isolate, out.str().c_str()).ToLocalChecked()); | ||
| Local<Value> ret; | ||
| if (ToV8Value(env->context(), out.str(), env->isolate()).ToLocal(&ret)) { |
There was a problem hiding this comment.
Unrelated to this Pr, but we should definitely rewrite this function to avoid calling std::ostringstream
anonrig
added
author ready
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
removed
the
request-ci
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as outdated.
This comment was marked as outdated.
legendecas
approved these changes
Feb 11, 2025
| FIXED_ONE_BYTE_STRING(isolate, "execArgv"), | ||
| ToV8Value(context, env->exec_argv()) | ||
| .ToLocalChecked()).Check(); | ||
| if (!ToV8Value(context, env->exec_argv()).ToLocal(&val) || |
There was a problem hiding this comment.
Probably worth to keep the comment.
Suggested change
| if (!ToV8Value(context, env->exec_argv()).ToLocal(&val) || | |
| // process.execArgv | |
| if (!ToV8Value(context, env->exec_argv()).ToLocal(&val) || |
| env->exec_path().size()) | ||
| .ToLocalChecked()) | ||
| .Check(); | ||
| if (!ToV8Value(context, env->exec_path(), isolate).ToLocal(&val) || |
There was a problem hiding this comment.
Same, better to keep the comment for searching.
Suggested change
| if (!ToV8Value(context, env->exec_path(), isolate).ToLocal(&val) || | |
| // process.execPath | |
| if (!ToV8Value(context, env->exec_path(), isolate).ToLocal(&val) || |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace multiple uses of ToLocalChecked