Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update testing documentation #56953

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Aditi-1400
Copy link

This update improves the test/common/README.md file by explaining why the common module is essential when writing tests.

I became curious about its importance while working on PR #56942, and @joyeecheung kindly provided the additional context that was missing from the documentation. :)

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Feb 7, 2025
Copy link
Member

@joyeecheung joyeecheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.13%. Comparing base (048a17a) to head (bcbb7c6).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #56953      +/-   ##
==========================================
- Coverage   89.15%   89.13%   -0.02%     
==========================================
  Files         665      665              
  Lines      192846   192846              
  Branches    37145    37144       -1     
==========================================
- Hits       171926   171893      -33     
- Misses      13696    13702       +6     
- Partials     7224     7251      +27     

see 23 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants