Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: improve error handling in multiple c++ files #56915

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Feb 4, 2025

Move away from ToLocalChecked() uses and handle errors properly in those cases

@jasnell jasnell requested review from legendecas and aduh95 February 4, 2025 16:02
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Feb 4, 2025
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 63.63636% with 32 lines in your changes missing coverage. Please review.

Project coverage is 89.19%. Comparing base (c4fb331) to head (af38a30).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/node_contextify.cc 61.90% 6 Missing and 10 partials ⚠️
src/encoding_binding.cc 56.25% 4 Missing and 3 partials ⚠️
src/inspector_agent.cc 37.50% 5 Missing ⚠️
src/node_credentials.cc 75.00% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #56915      +/-   ##
==========================================
- Coverage   89.21%   89.19%   -0.02%     
==========================================
  Files         665      665              
  Lines      192514   192540      +26     
  Branches    37040    37057      +17     
==========================================
- Hits       171744   171736       -8     
- Misses      13613    13617       +4     
- Partials     7157     7187      +30     
Files with missing lines Coverage Δ
src/inspector_js_api.cc 86.39% <100.00%> (+0.10%) ⬆️
src/node_credentials.cc 68.43% <75.00%> (-0.29%) ⬇️
src/inspector_agent.cc 79.49% <37.50%> (-0.26%) ⬇️
src/encoding_binding.cc 78.45% <56.25%> (-1.78%) ⬇️
src/node_contextify.cc 80.71% <61.90%> (-0.66%) ⬇️

... and 32 files with indirect coverage changes

@aduh95
Copy link
Contributor

aduh95 commented Feb 4, 2025

Linter is failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants