Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module: fix jsdoc for format parameter in cjs/loader #56501

Merged
merged 4 commits into from
Jan 15, 2025
Merged

module: fix jsdoc for format parameter in cjs/loader #56501

merged 4 commits into from
Jan 15, 2025

Conversation

pacexy
Copy link
Contributor

@pacexy pacexy commented Jan 7, 2025 •
edited
Loading

Before:
Snipaste_2025-01-07_20-27-10-resized

After:
Snipaste_2025-01-07_21-11-58-resized

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-bot nodejs-github-bot added module Issues and PRs related to the module subsystem. needs-ci PRs that need a full CI run. labels Jan 7, 2025
@pacexy pacexy changed the title module: fix jsdoc for format parameter module: fix jsdoc for format parameter in cjs/loader Jan 7, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64459/

@jasnell jasnell added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jan 12, 2025
jazelly
jazelly requested changes Jan 12, 2025
View reviewed changes
lib/internal/modules/cjs/loader.js Outdated Show resolved Hide resolved
@jasnell jasnell removed commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jan 12, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 12, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.19%. Comparing base (52c6449) to head (fb57c7d).
Report is 72 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #56501      +/-   ##
==========================================
+ Coverage   89.12%   89.19%   +0.06%     
==========================================
  Files         662      662              
  Lines      191555   191801     +246     
  Branches    36856    36918      +62     
==========================================
+ Hits       170730   171073     +343     
+ Misses      13696    13566     -130     
- Partials     7129     7162      +33
Files with missing lines Coverage Δ
lib/internal/modules/cjs/loader.js 98.11% <100.00%> (-0.01%) ⬇️

... and 64 files with indirect coverage changes

@jazelly
Copy link
Member

jazelly commented Jan 13, 2025 •
edited
Loading

Can you please update your first commit message to meet our guideline? I think you did it right for the title in this PR but the GHA would check it against your first commit.

@pacexy
Copy link
Contributor Author

pacexy commented Jan 13, 2025

Can you please update your first commit message to meet our guideline? I think you did it right for the title in this PR but the GHA would check it against your first commit.

updated

@jazelly jazelly added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed needs-ci PRs that need a full CI run. labels Jan 14, 2025
@jazelly
Copy link
Member

jazelly commented Jan 14, 2025

there's a lint issue

@pacexy
Copy link
Contributor Author

pacexy commented Jan 14, 2025

there's a lint issue

oh sorry, I have fixed it.

@aduh95 aduh95 added the typings label Jan 15, 2025
@aduh95 aduh95 merged commit c8df98d into nodejs:main Jan 15, 2025
26 checks passed
@aduh95
Copy link
Contributor

aduh95 commented Jan 15, 2025

Landed in c8df98d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsumners-nr jsumners-nr jsumners-nr approved these changes

@jazelly jazelly jazelly approved these changes

@Ayase-252 Ayase-252 Ayase-252 approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. module Issues and PRs related to the module subsystem. typings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@pacexy @nodejs-github-bot @jazelly @aduh95 @jasnell @Ayase-252 @jsumners-nr