doc: allow request for TSC reviews via the GitHub UI #56493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
This is why historically - #22759. I'm not sure if it's still relevant or not. |
anonrig
approved these changes
Jan 6, 2025
RafaelGSS
approved these changes
Jan 6, 2025
gireeshpunathil
approved these changes
Jan 7, 2025
UlisesGascon
approved these changes
Jan 7, 2025
marco-ippolito
approved these changes
Jan 7, 2025
aduh95
added
author ready
jasnell
approved these changes
Jan 7, 2025
lpinca
approved these changes
Jan 7, 2025
nodejs-github-bot
removed
the
commit-queue
|
Landed in 5747828 |
targos
pushed a commit
that referenced
this pull request
Jan 13, 2025
PR-URL: #56493 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Jan 13, 2025
PR-URL: nodejs#56493 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I might be missing some context on why we’re not doing that, but IMO it would make perfect sense for semver-major PRs, as it’s basically the only time where TSC voting members reviews have a different weight. Requesting a review from the team would allow GH UI to highlight those reviews (useful for newcomers who are less likely to have all the TSC members handles in mind). It would require us to give the
@nodejs/TSCteam Triage role on the repo, which should not change anything as TSC voting members are already collaborators (which have Write role on the repo).EDIT: from my understanding of #22759, it seems the rule was put in place because of the lack of support for filtering/filtering out notifications coming from team reviews, which was problematic for folks using GitHub professionally and couldn't/wouldn't involve Node.js collaboration during paid hours. It looks like the issue still exists, I have to say it's kind of crazy GitHub doesn't even support filtering out an org from the notification feed – but it does support that when searching for PRs. However, I'd still be open to trying it out again, even if GitHub notification feed filtering hasn't changed much since 2018, the Node.js project has, so it might just work for the current project members.