-
Notifications
You must be signed in to change notification settings - Fork 30.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: fix vcbuild test
when path contain spaces
#56481
Open
stduhpf
wants to merge
2
commits into
nodejs:main
Choose a base branch
from
stduhpf:vcbuild-test-spaces
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
Issues and PRs related to build files or the CI.
needs-ci
PRs that need a full CI run.
windows
Issues and PRs related to the Windows platform.
labels
Jan 5, 2025
stduhpf
force-pushed
the
vcbuild-test-spaces
branch
from
January 5, 2025 16:58
64b16c5
to
7a4087c
Compare
stduhpf
changed the title
tools: fix cbuild test when path contain spaces
tools: fix Jan 5, 2025
vcbuild test
when path contain spaces
aduh95
approved these changes
Jan 5, 2025
aduh95
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Jan 5, 2025
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jan 5, 2025
lpinca
reviewed
Jan 5, 2025
Co-authored-by: Luigi Pinca <[email protected]>
lpinca
approved these changes
Jan 5, 2025
lpinca
added
commit-queue
Add this label to land a pull request using GitHub Actions.
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Jan 5, 2025
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jan 5, 2025
aduh95
removed
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
commit-queue
Add this label to land a pull request using GitHub Actions.
labels
Jan 5, 2025
Related failure on Windows:
Dropping/Reverting c33319c should fix the issue. |
Adding the following patch without reverting c33319c should also fix the issue. diff --git a/vcbuild.bat b/vcbuild.bat
index f93998d2b1..c5fd1a5d0c 100644
--- a/vcbuild.bat
+++ b/vcbuild.bat
@@ -590,9 +590,7 @@ if not defined doc if not defined build_addons (
)
if exist "tools\doc\node_modules\unified\package.json" goto skip-install-doctools
SETLOCAL
-cd tools\doc
-%npm_exe% ci
-cd ..\..
+%npm_exe% --prefix tools\doc ci
if errorlevel 1 goto exit
ENDLOCAL
:skip-install-doctools
@@ -735,9 +733,7 @@ goto lint-js-build
:lint-js-build
if not defined lint_js_build if not defined lint_js if not defined lint_js_fix goto lint-md-build
-cd tools\eslint
-%npm_exe% ci
-cd ..\..
+%npm_exe% --prefix tools\eslint ci
:lint-js
if not defined lint_js goto lint-js-fix
@@ -755,9 +751,7 @@ goto lint-md-build
:lint-md-build
if not defined lint_md if not defined format_md goto lint-md
-cd tools\lint-md
-%npm_exe% ci
-cd ..\..
+%npm_exe% --prefix tools\lint-md ci
:lint-md
if not defined lint_md goto format-md
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
build
Issues and PRs related to build files or the CI.
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
needs-ci
PRs that need a full CI run.
windows
Issues and PRs related to the Windows platform.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.