Skip to content

Commit

Permalink
chore(git-node): add make lint-md reminder
Browse files Browse the repository at this point in the history
After two consecutive releases in which I mistakely pushed a broken
release commit to main, I'm convinced that the process needs
improvement.

This changeset proposes to add a reminder to `git node release promote`
to lint markdown files prior to pushing branches to upstream remote.

Refs: nodejs/node@a344300
Refs: nodejs/node#56508
  • Loading branch information
ruyadorno committed Jan 8, 2025
1 parent 4bd6820 commit f2ad232
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions lib/promote_release.js
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,12 @@ export default class ReleasePromotion extends Session {
}
}

cli.separator();
cli.warn('Reminder: Lint markdown files');
cli.info('You might need to amend the commit if there are issues:');
cli.info('make lint-md');
cli.separator();

// Push to the remote the release tag, and default, release, and staging branch.
await this.pushToRemote(workingOnNewReleaseCommit);

Expand Down

0 comments on commit f2ad232

Please sign in to comment.