Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][cli] PIP-343: Use picocli instead of jcommander in bin/pulsar #32

Closed
wants to merge 1 commit into from

Conversation

nodece
Copy link
Owner

@nodece nodece commented Mar 15, 2024

Fixes #xyz

Main Issue: #xyz

PIP: #xyz

Motivation

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@nodece nodece force-pushed the pip-343-pulsar-cli branch 9 times, most recently from e7f64fa to a02cd92 Compare March 17, 2024 06:14
@nodece
Copy link
Owner Author

nodece commented Mar 17, 2024

/pulsarbot rerun-failure-checks

@nodece nodece force-pushed the pip-343-pulsar-cli branch 3 times, most recently from b12f447 to 39bbbdb Compare March 19, 2024 15:17
@nodece nodece force-pushed the pip-343-pulsar-cli branch from 39bbbdb to 36be27e Compare March 20, 2024 04:17
@nodece nodece closed this Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant