feat: use byte@2 and remove debug, utility deps

[fengmk2]

No description provided.

[coderabbitai]

Important

Review Skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[socket-security]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/[email protected]	Transitive: environment, filesystem, network, shell	+15	284 kB	gxcsoccer

🚮 Removed packages: npm/[email protected]

View full report↗︎

[sweep-ai]

Sweep: PR Review

Authors of pull request: @fengmk2

This pull request aimed to reduce external dependencies and streamline the debugging process in the codebase.

The has function, previously imported from the 'utility' module, was redefined locally in lib/object.js. This change made the code more self-contained and eliminated the need for an external dependency for property-checking logic.

The debug module was replaced with Node.js's built-in util.debuglog function across multiple files (lib/utils.js, lib/v1/decoder.js, lib/v1/encoder.js, lib/v2/decoder.js, and lib/v2/encoder.js). This change standardized the debugging mechanism and potentially simplified the dependency management.

In lib/v2/encoder.js, the isSafeNumberString function was introduced locally to replace the same function from the 'utility' module. This function checks if a number string can be safely converted to a JavaScript Number, ensuring safe handling of large integers.

Additionally, several unused imports were removed from lib/v2/encoder.js, including is-type-of, javaObject, and utility, further reducing unnecessary dependencies and potentially improving code maintainability.

---

Sweep Found These Issues

lib/object.js

• Sweep has identified a redundant function: The new function has is redundant as its functionality is already provided by exports.hasOwnProperty in lib/utils.js.

hessian.js/lib/object.js

Lines 169 to 171 in ddc5e38

	function has(obj, prop) {
	return Object.prototype.hasOwnProperty.call(obj, prop);
	}


View Diff

lib/utils.js

• Switching from 'debug' to 'util'.debuglog may change the behavior of how debug messages are logged, potentially affecting log visibility and management.

hessian.js/lib/utils.js

Line 12 in ddc5e38

var debug = require('util').debuglog('hessian.js:utils');


View Diff

lib/v1/decoder.js

• Switching from 'debug' to 'util.debuglog' may change how debug messages are filtered or displayed, potentially causing issues in environments where the 'debug' module's features are relied upon.

hessian.js/lib/v1/decoder.js

Line 13 in ddc5e38

var debug = require('util').debuglog('hessian:v1:decoder');


View Diff

lib/v1/encoder.js

• Switching from the debug module to util.debuglog may change the behavior of debug message logging, potentially affecting how and when debug messages are displayed based on the NODE_DEBUG environment variable.

hessian.js/lib/v1/encoder.js

Line 14 in ddc5e38

var debug = require('util').debuglog('hessian:v1:encoder');


View Diff

lib/v2/encoder.js

• Removing the javaObject module import without replacing its functionality could lead to runtime errors if Java object handling was used elsewhere in the code.

hessian.js/lib/v2/encoder.js

Lines 3 to 7 in ddc5e38

	var debug = require('util').debuglog('hessian:v2:encoder');
	var util = require('util');
	var EncoderV1 = require('../v1/encoder');
	var Long = require('long');
	var float32Test = require('../utils').float32Test;


View Diff

---

package.json was not reviewed because our filter identified it as typically a non-human-readable or less important file (e.g., dist files, package.json, images). If this is an error, please let us know.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.67%. Comparing base (b9b5766) to head (dfb0967).
Report is 5 commits behind head on 1.x.

Additional details and impacted files

@@            Coverage Diff             @@
##              1.x     #140      +/-   ##
==========================================
+ Coverage   94.60%   94.67%   +0.06%     
==========================================
  Files           9        9              
  Lines        1113     1145      +32     
  Branches      195      203       +8     
==========================================
+ Hits         1053     1084      +31     
- Misses         60       61       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.