Upgrade tcell to v2.8.0 and add support for Underline style and color #680
Conversation
noborus
commented
Jan 10, 2025
noborus
commented
- Upgraded tcell to version v2.8.0.
- Added support for Underline style and color in ov.
- Modified oviewer/convert_es.go to handle the new Underline styles and colors.
- Updated oviewer/ovstyle.go to apply the new Underline styles and colors.
- Upgraded other modules.
- Upgraded tcell to version v2.8.0. - Added support for Underline style and color in ov. - Modified oviewer/convert_es.go to handle the new Underline styles and colors. - Updated oviewer/ovstyle.go to apply the new Underline styles and colors. - Upgraded other modules.
oviewer/ovstyle.go
Outdated
| return 0 | ||
| } | ||
| if tcell.UnderlineStyle(n) > tcell.UnderlineStyleDashed { | ||
| return 0 |
There was a problem hiding this comment.
Is there no constants for this 0 ?
There was a problem hiding this comment.
Yes, there is. I'll fix it, thanks.
| // underLineStyle sets the underline style. | ||
| // only support 0-5. | ||
| // 0: None, 1: Single, 2: Double, 3: Curly, 4: Dotted, 5: Dashed |
There was a problem hiding this comment.
About this
Maybe you could link the constants here with a godoc link
Something like this (pseudo code)
| // underLineStyle sets the underline style. | |
| // only support 0-5. | |
| // 0: None, 1: Single, 2: Double, 3: Curly, 4: Dotted, 5: Dashed | |
| // underLineStyle sets the underline style. | |
| // only support 0-5. | |
| // 0: [tview.WhateverNone], 1: [tview.WhateverSingle], 2: Double, 3: Curly, 4: Dotted, 5: Dashed |
oviewer/ovstyle.go
Outdated
| if err != nil { | ||
| return 0 | ||
| } | ||
| if tcell.UnderlineStyle(n) > tcell.UnderlineStyleDashed { |
There was a problem hiding this comment.
This looks strange
I assume you only wanto support 0-5 range, but these are iota, I assume. So comparing them is a but strange
I would use a switch with the exact value you support in one case.
Also, if you only supports the value "0", "1", maybe you could avoid the string to int conversion
There was a problem hiding this comment.
This is how to do the behavior of an unauthorized value outside the specifications.
The operation changes with Terminal-Emulator, so it may change in the future.
Originally, it is derived from the escape sequence specification, so it doesn't matter much whether it is an iota.
noburus is not a person concerned. 😥
There was a problem hiding this comment.
Wow, a double wrong ping 🤦♂️
