Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VisionOS support to Swift Package Manager Package.swift definition file #4611

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

richardtop
Copy link
Contributor

Since the release of Apple Vision Pro hardware, it's now possible to run C++ code when targeting Vision OS. This change enables support for VisionOS in this package, so that the C++-based products can now leverage this library when being built for the AVP hardware.

  • The changes are described in detail, both the what and why.
  • If applicable, an existing issue is referenced.
  • The Code coverage remained at 100%. A test case for every new line of code.
  • If applicable, the documentation is updated.
  • The source code is amalgamated by running make amalgamate.

Read the Contribution Guidelines for detailed information.

@richardtop richardtop requested a review from nlohmann as a code owner January 20, 2025 04:41
@github-actions github-actions bot added the S label Jan 20, 2025
@coveralls
Copy link

coveralls commented Jan 20, 2025

Coverage Status

coverage: 99.186%. remained the same
when pulling 6e58eaf on richardtop:vision_os_spm_support
into f06604f on nlohmann:develop.

Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check https://github.com/nlohmann/json/pull/4611/checks?check_run_id=35854078785 on how to resolve the DCO warning.

@richardtop richardtop force-pushed the vision_os_spm_support branch 3 times, most recently from a085b33 to 645a834 Compare January 20, 2025 07:38
@richardtop
Copy link
Contributor Author

@nlohmann Please check, I've fixed this, I'm not sure why this dco action is failing now.

@nlohmann
Copy link
Owner

This is from the DCO action:

Commit sha: 645a834, Author: Richard Topchii, Committer: Richard Topchii; Expected "Richard Topchii [email protected]", but got "Richard Topchii [email protected]".

@richardtop
Copy link
Contributor Author

Clear, so the emails must match. I'm adjusting this now.

@richardtop richardtop force-pushed the vision_os_spm_support branch from 645a834 to 6e58eaf Compare January 20, 2025 08:19
@richardtop
Copy link
Contributor Author

@nlohmann Please check again, I've finally fixed this issue with your suggestion.

Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann added this to the Release 3.11.4 milestone Jan 20, 2025
@nlohmann
Copy link
Owner

Thanks! Though I wonder if anyone would actually use this library in a Swift project.

@nlohmann nlohmann merged commit 1b81351 into nlohmann:develop Jan 20, 2025
130 checks passed
@richardtop
Copy link
Contributor Author

@nlohmann guess why this file got added here in the first place. The answer is "hell yeah!" and thanks for the great library.
In fact, I've demoed the way to integrate this library with a C++ project which later is integrated into Swift app: https://www.youtube.com/watch?v=DSLRObswE3Y

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants