-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VisionOS support to Swift Package Manager Package.swift definition file #4611
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check https://github.com/nlohmann/json/pull/4611/checks?check_run_id=35854078785 on how to resolve the DCO warning.
a085b33
to
645a834
Compare
@nlohmann Please check, I've fixed this, I'm not sure why this dco action is failing now. |
This is from the DCO action:
|
Clear, so the emails must match. I'm adjusting this now. |
…n file Signed-off-by: Richard Topchii <[email protected]>
645a834
to
6e58eaf
Compare
@nlohmann Please check again, I've finally fixed this issue with your suggestion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Thanks! Though I wonder if anyone would actually use this library in a Swift project. |
@nlohmann guess why this file got added here in the first place. The answer is "hell yeah!" and thanks for the great library. |
Since the release of Apple Vision Pro hardware, it's now possible to run C++ code when targeting Vision OS. This change enables support for VisionOS in this package, so that the C++-based products can now leverage this library when being built for the AVP hardware.
make amalgamate
.Read the Contribution Guidelines for detailed information.