Improve Search Algorithm #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ijemmao
commented
Jun 16, 2024
| @@ -592,7 +592,7 @@ describe('MongoDB Words', () => { | |||
| }); | |||
|
|
|||
| describe('/GET mongodb words V2', () => { | |||
| it('return word parts of mgba for noun deconstruction', async () => { | |||
| it.skip('return word parts of mgba for noun deconstruction', async () => { | |||
There was a problem hiding this comment.
skipping for now since we no longer call expandNoun
ijemmao
commented
Jun 16, 2024
| @@ -28,7 +28,7 @@ | |||
| "dev:full:database": "npm-run-all -p start:watch start:emulators start:database:replica", | |||
| "dev:light": "npm-run-all -p start:watch start:database", | |||
| "dev:site": "npm-run-all -p start:emulators dev:site:next", | |||
| "dev:site:next": "firebase functions:config:set runtime.env=development && next", | |||
| "dev:site:next": "firebase functions:config:set runtime.env=development && next -p 3035", | |||
There was a problem hiding this comment.
explicitly setting the dev port to avoid clashing with other nkowaokwu projects
ijemmao
commented
Jun 16, 2024
| })) | ||
| : // @ts-expect-error no index signature with parameter type string | ||
| [{ text: searchWordPart, wordClass: [], regex: regexes[searchWordPart] }]; | ||
| // if (!keywords.length && searchWord) { |
There was a problem hiding this comment.
no longer calling expandNoun to avoid false matches
ijemmao
commented
Jun 16, 2024
| )}${'\u1e44\u01f9\u0144\u1e45\u01f8\u0143]'.normalize('NFC')}+[\u00B4\u0301\u0060\u00AF\u0304\u0323\u0300]{0,}`; | ||
| const caseInsensitiveM = `${'[m\u1e44\u01f9\u0144M\u1e45\u01f8\u0143'.normalize( | ||
| )}${'\u1e44\u01f9\u0144\u1e45\u01f8\u0143]'.normalize('NFC')}+[${ALL_DIACRITICS}]{0,}`; | ||
| const caseInsensitiveM = `${'[m\u1e40\u1e3fM\u1e41\u1e3e'.normalize( |
There was a problem hiding this comment.
turns out we copied the letter N's Unicode values instead of the letter M's
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
expandNounhelper function. This helper function has been leading to a lot of false matches which confuses end users and ultimately lowers their trust in the quality of the platform.wordReg,definitionsReg, andexamplesRegwould not only include the letter m but also the letter m in the regexes, which led to a lot of false matches.Issue ticket number and link
Closed #785
Motivation and Context
Recently the quality of search has been pretty low.
How Has This Been Tested?
Ran all unit tests locally and updated stale tests.
Screenshots (if appropriate):
N/A