Fallback to Developer Email When Creating Firebase Account #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o/fix-production
…o/fix-production
ijemmao
added a commit
that referenced
this pull request
Jun 16, 2024
)" This reverts commit 59f7ecf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
The
developerAuthorizationmiddleware will now look up Developer documents living in MongoDB by email rather than Firebase Id. This is a better approach because in the case where a developer already has a Developer account with the Igbo API (a.k.a. they have a Developer document in our MongoDB database) we can look up their existing Developer account with the newly created Firebase account's email.If we continue to look up developers by their Firebase Id, we wouldn't be able to find any Developer document since the
firebaseIdon an existing Developer document wouldn't match with a newly created Firebase Id.Issue ticket number and link
N/A
Motivation and Context
Fixing a big bug that would have prevented many existing Igbo API Developers from logging into the dashboard and seeing their personal information
How Has This Been Tested?
Updated existing Jest unit tests.
Screenshots (if appropriate):
N/A