Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotations #190

Merged
merged 13 commits into from
Dec 22, 2021
Merged

Annotations #190

merged 13 commits into from
Dec 22, 2021

Conversation

mrbermell
Copy link
Collaborator

@mrbermell mrbermell commented Nov 24, 2021 •
edited
Loading

Starts work with #183 .

solves a small bug with how python pathfinding interacts with the forward model.

Adds repr() for some of the models.

@mrbermell mrbermell added this to the Bot Bowl IV milestone Dec 5, 2021
@mrbermell mrbermell mentioned this pull request Dec 7, 2021
Merged
@njustesen njustesen self-requested a review December 14, 2021 11:19
@mrbermell mrbermell changed the title [WIP] Annotations in game.py and misc Annotations Dec 21, 2021
njustesen
njustesen approved these changes Dec 21, 2021
View reviewed changes
Copy link
Owner

@njustesen njustesen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Only a few minor comments. Feels free to merge,

Btw. have you checked if PyCharm gives any warnings now that the type annotations are added?
Code -> Inspect code

@mrbermell mrbermell merged commit 338a4b4 into njustesen:master Dec 22, 2021
@mrbermell mrbermell deleted the annotations-and-repr branch December 22, 2021 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njustesen njustesen njustesen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Bot Bowl IV Announcement
Development

Successfully merging this pull request may close these issues.
2 participants
@mrbermell @njustesen