autoscaling/V2 for HorizontalPodAutoscaler, servicesGeneral support and serviceAccount name fix #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-silvius
commented
Oct 3, 2024
s-silvius
commented
- Added support for autoscaling/V2 api for HPA. Change that also to default. Keep supporting autoscaling/v2beta1
- added support for serviceGeneral to able to add common labels and annotations to all services
Change also default apiVersion to autoscaling/v2 but support still autoscaling/v2beta1. Signed-off-by: Samuli Silvius <[email protected]>
Added servicesGeneral.labels servicesGeneral.annotations Signed-off-by: Samuli Silvius <[email protected]>
serviceAccountName in pod did not matched the given name in values as ServiceAccount resource in using
helpers.app.fullname template
```
name: {{ include "helpers.app.fullname" (dict "name" $name "context" $) }}
```
So, use same template in pod to reference serviceAccount name to make them match.
Signed-off-by: Samuli Silvius <[email protected]>
s-silvius
changed the title
Conditional part used template that did not existed. Signed-off-by: Samuli Silvius <[email protected]>
…essProbe Container specific properties are merged with generic ones so that specific ones will override generic properties. Signed-off-by: Samuli Silvius <[email protected]>
…rsion When nxs-universal-chart used as library chart as dependency, parent chart name and version can be used to override following values in labels: app.kubernetes.io/name helm.sh/chart app.kubernetes.io/version instead of nxs chart values. `app.kubernetes.io/name` is important to be override as used as part of selectorLabels and this way parent chart's name is used in each resource in addition to release name. Without this override this label get release name as the value, i.e. value is same as for the other label `app.kubernetes.io/instance` in the selector. If both parentChart.name and parentChart.version is given `helm.sh/chart` will be using those values instead of Chart.Name and Chart.Version whihc are values of nxs chart. For `app.kubernetes.io/version` label the value from parentChart.version is used if given instead of Chart.Appversion or Chart.version. Signed-off-by: Samuli Silvius <[email protected]>
|
Looking so forward to have this one merged!! 😍 |
Previously only single Role and ClusterRole was possible per serviceAccount as role/clusterrole was a map entry. Changed to both to list allows multiple roles/clusterroles. Rules under each role/clusterrole are same as earlier. Signed-off-by: Samuli Silvius <[email protected]>
It's possible and normal valid use case to bind ClusterRole with RoleBinding to allow clusterlevel privileges to namespace level. Added new `clusterScope` boolean parameter for role object and if value is true ClusterRole is used in releRef, otherwice Role is used. Default value is false. Signed-off-by: Samuli Silvius <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.