feat: updates generateTypeHelper to use type keyword and updates prettier #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tier version * adds support for verbatimModuleSyntax * adds support for user defined prettier config * updates prettier and related dependencies to latest versions BREAKING CHANGE: Typescript < 3.8 is no longer supported, please update to typescript >= 3.8 COMPLETES: nivekcode#242
JoA-MoS
force-pushed
the
adds-type-keyword-to-import
branch
from
c355c00 to
2f3d9ee
Compare
nivekcode
approved these changes
Feb 18, 2024
There was a problem hiding this comment.
@JoA-MoS The changes look good, I guess we now have trailing comma due to the prettier bump which probably also introduced a change in the defaults. I personally don't have strong opinions on wether to use trailing comma or not. Therefore relying on the prettier default is fine by me.
Thx a lot for the PR and the awesome work here 💪
|
@all-contributors please add @JoA-MoS for bug code ideas test |
|
@kreuzerk I've put up a pull request to add @JoA-MoS! 🎉 |
|
🎉 This PR is included in version 12.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Typescript < 3.8 is no longer supported, please update to typescript >= 3.8
COMPLETES: #242
Files with functional changes unrelated to prettier write: