fix(drop): handle nested DOM structures

nivekcode · Apr 18, 2019 · 02a3730 · 02a3730
1 parent 8709d82
commit 02a3730
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 11 deletions.
diff --git a/projects/ng-sortgrid/src/lib/ngsg-elements.helper.ts b/projects/ng-sortgrid/src/lib/ngsg-elements.helper.ts
@@ -3,4 +3,12 @@ export class NgsgElementsHelper {
     const allElements = element.parentNode.children;
     return Array.prototype.indexOf.call(allElements, element);
   }
+
+  public static findHost(element: Element, selector: string): Element {
+    const parentElement = element.parentElement;
+    if (parentElement.matches(selector)) {
+      return parentElement;
+    }
+    this.findHost(parentElement, selector);
+  }
 }
diff --git a/projects/ng-sortgrid/src/lib/ngsg-item.directive.ts b/projects/ng-sortgrid/src/lib/ngsg-item.directive.ts
@@ -10,15 +10,16 @@ import {
   Output
 } from '@angular/core';
 
-import { NgsgReflectService } from './ngsg-reflect.service';
-import { NgsgStoreService } from './ngsg-store.service';
-import { NgsgSortService } from './ngsg-sort.service';
-import { NgsgSelectionService } from './ngsg-selection.service';
-import { NgsgClassService } from './ngsg-class.service';
+import {NgsgReflectService} from './ngsg-reflect.service';
+import {NgsgStoreService} from './ngsg-store.service';
+import {NgsgSortService} from './ngsg-sort.service';
+import {NgsgSelectionService} from './ngsg-selection.service';
+import {NgsgClassService} from './ngsg-class.service';
+import {NgsgElementsHelper} from './ngsg-elements.helper';
 
-@Directive({
-  selector: '[ngSortgridItem]'
-})
+const selector = '[ngSortgridItem]';
+
+@Directive({selector})
 export class NgsgItemDirective implements OnInit, AfterViewInit {
   private DEFAULT_GROUP = 'defaultGroup';
 
@@ -37,7 +38,8 @@ export class NgsgItemDirective implements OnInit, AfterViewInit {
     private reflectService: NgsgReflectService,
     private classService: NgsgClassService,
     private ngsgStore: NgsgStoreService
-  ) {}
+  ) {
+  }
 
   ngOnInit(): void {
     // TODO handle classes as input
@@ -54,13 +56,16 @@ export class NgsgItemDirective implements OnInit, AfterViewInit {
 
   @HostListener('dragstart', ['$event'])
   dragStart(event): void {
+    if (!this.occuredOnHost(event)) {
+      return;
+    }
     this.selectionService.selectElementIfNoSelection(this.ngSortGridGroup, event.target);
     this.sortService.initSort(this.ngSortGridGroup);
   }
 
   @HostListener('dragenter', ['$event'])
   dragEnter(event): void {
-    if (!this.ngsgStore.hasSelectedItems(this.ngSortGridGroup)) {
+    if (!this.ngsgStore.hasSelectedItems(this.ngSortGridGroup) || !this.occuredOnHost(event)) {
       return;
     }
     this.sortService.sort(event.target);
@@ -88,7 +93,12 @@ export class NgsgItemDirective implements OnInit, AfterViewInit {
 
   @HostListener('click', ['$event'])
   clicked(event): void {
+    const element = !this.occuredOnHost(event) ? NgsgElementsHelper.findHost(event.target, selector) : event.target;
     this.selected = !this.selected;
-    this.selectionService.updateSelectedDragItem(this.ngSortGridGroup, event.target, this.selected);
+    this.selectionService.updateSelectedDragItem(this.ngSortGridGroup, element, this.selected);
+  }
+
+  private occuredOnHost(event): boolean {
+    return event.target.matches(selector);
   }
 }