Skip to content

Commit

Permalink
Consistently use development group in Gemfiles
Browse files Browse the repository at this point in the history
Using a `development` group isn't really necessary, because all these
Gemfiles are only ever used in the context of development, linting or
running the tests. However, it would be good to be consistent and
using a `development` group probably make things clearer.

Previously we were only using a group in
`gemfiles/Gemfile.minitest.latest` &
`gemfiles/Gemfile.test-unit.latest`.

Closes freerange#706.
  • Loading branch information
floehopper committed Jan 1, 2025
1 parent 1207992 commit 4fe8391
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 13 deletions.
22 changes: 12 additions & 10 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,18 @@ source 'https://rubygems.org'

gemspec

gem 'introspection', '~> 0.0.1'
gem 'minitest'
gem 'rake'
group :development do
gem 'introspection', '~> 0.0.1'
gem 'minitest'
gem 'rake'

if RUBY_ENGINE == 'jruby'
# Workaround for https://github.com/jruby/jruby/issues/8488
gem 'jar-dependencies', '~> 0.4.1'
end
if RUBY_ENGINE == 'jruby'
# Workaround for https://github.com/jruby/jruby/issues/8488
gem 'jar-dependencies', '~> 0.4.1'
end

if ENV['MOCHA_GENERATE_DOCS']
gem 'redcarpet'
gem 'yard'
if ENV['MOCHA_GENERATE_DOCS']
gem 'redcarpet'
gem 'yard'
end
end
8 changes: 5 additions & 3 deletions gemfiles/Gemfile.rubocop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ source 'https://rubygems.org'

gemspec path: '../'

gem 'rake'
gem 'rubocop'
gem 'rubocop-rake'
group :development do
gem 'rake'
gem 'rubocop'
gem 'rubocop-rake'
end

0 comments on commit 4fe8391

Please sign in to comment.