Eliminate the util/crud.go

Split out the drpolicy function to drpolicy.go and rename the file to
namespace.go. Now we can understand better the structure of the util
package.

Signed-off-by: Nir Soffer <[email protected]>

e2e/util/drpolicy.go

@@ -0,0 +1,27 @@
+// SPDX-FileCopyrightText: The RamenDR authors
+// SPDX-License-Identifier: Apache-2.0
+
+package util
+
+import (
+	"context"
+
+	ramen "github.com/ramendr/ramen/api/v1alpha1"
+	"k8s.io/apimachinery/pkg/types"
+	"sigs.k8s.io/controller-runtime/pkg/client"
+)
+
+const DefaultDRPolicyName = "dr-policy"
+
+// nolint:unparam
+func GetDRPolicy(client client.Client, name string) (*ramen.DRPolicy, error) {
+	drpolicy := &ramen.DRPolicy{}
+	key := types.NamespacedName{Name: name}
+
+	err := client.Get(context.Background(), key, drpolicy)
+	if err != nil {
+		return nil, err
+	}
+
+	return drpolicy, nil
+}

e2e/util/crud.go → e2e/util/namespace.go

@@ -13,13 +13,10 @@ import (
 	"k8s.io/apimachinery/pkg/types"
 	"sigs.k8s.io/controller-runtime/pkg/client"
 
-	ramen "github.com/ramendr/ramen/api/v1alpha1"
 	corev1 "k8s.io/api/core/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 )
 
-const DefaultDRPolicyName = "dr-policy"
-
 func CreateNamespace(client client.Client, namespace string) error {
 	ns := &corev1.Namespace{
 		ObjectMeta: metav1.ObjectMeta{
@@ -116,16 +113,3 @@ func AddNamespaceAnnotationForVolSync(client client.Client, namespace string) er
 
 	return client.Update(context.Background(), objNs)
 }
-
-// nolint:unparam
-func GetDRPolicy(client client.Client, name string) (*ramen.DRPolicy, error) {
-	drpolicy := &ramen.DRPolicy{}
-	key := types.NamespacedName{Name: name}
-
-	err := client.Get(context.Background(), key, drpolicy)
-	if err != nil {
-		return nil, err
-	}
-
-	return drpolicy, nil
-}