Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump minimum Python, rerun auto style fixes #93

Merged
merged 3 commits into from
Jan 14, 2025

Conversation

effigies
Copy link
Member

Ruff is complaining that cli.parser shadows parser, which hasn't existed since Python 3.9. This bumps the minimum Python to 3.10, which shuts ruff up about that, and then it has auto-fixes for pyupgrade complaints.

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 30.59%. Comparing base (89c0110) to head (5cce6f5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/fmripost_aroma/cli/workflow.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #93   +/-   ##
=======================================
  Coverage   30.59%   30.59%           
=======================================
  Files          26       26           
  Lines        2363     2363           
  Branches      286      286           
=======================================
  Hits          723      723           
  Misses       1617     1617           
  Partials       23       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies merged commit 999b3f5 into nipreps:main Jan 14, 2025
12 checks passed
@effigies effigies deleted the mnt/minver branch January 14, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant