Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write out denoised data to requested output spaces #44

Merged
merged 5 commits into from
Sep 3, 2024
Merged

Write out denoised data to requested output spaces #44

merged 5 commits into from
Sep 3, 2024

Conversation

tsalo
Copy link
Collaborator

@tsalo tsalo commented Aug 7, 2024

This is just to stash my old attempt with the resampling workflow. Not currently working.

Changes proposed in this pull request

  • Add the --output-spaces parameter.
  • Use init_template_iterator_wf to loop over requested output spaces and warp the denoised data to those spaces.

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 5.00000% with 19 lines in your changes missing coverage. Please review.

Project coverage is 31.28%. Comparing base (e1b6819) to head (1d37a53).

Files with missing lines Patch % Lines
src/fmripost_aroma/workflows/base.py 5.55% 17 Missing ⚠️
src/fmripost_aroma/cli/parser.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
- Coverage   31.38%   31.28%   -0.11%     
==========================================
  Files          26       26              
  Lines        2278     2289      +11     
  Branches      360      361       +1     
==========================================
+ Hits          715      716       +1     
- Misses       1542     1552      +10     
  Partials       21       21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsalo tsalo changed the title Implement output-spaces. Implement output-spaces Aug 7, 2024
@tsalo
Copy link
Collaborator Author

tsalo commented Aug 29, 2024

I think this is the last thing we need to get working before we release 24.0.0.

@tsalo tsalo changed the title Implement output-spaces Write out denoised data to requested output spaces Aug 29, 2024
@tsalo tsalo changed the base branch from main to output-spaces September 3, 2024 16:13
@tsalo tsalo marked this pull request as ready for review September 3, 2024 16:15
@tsalo tsalo merged commit 07e904f into nipreps:output-spaces Sep 3, 2024
1 check was pending
@tsalo tsalo deleted the output-spaces branch September 3, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant