-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft CircleCI configuration #43
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #43 +/- ##
==========================================
- Coverage 31.18% 30.54% -0.64%
==========================================
Files 26 26
Lines 2155 2259 +104
Branches 327 358 +31
==========================================
+ Hits 672 690 +18
- Misses 1463 1549 +86
Partials 20 20 ☔ View full report in Codecov by Sentry. |
@effigies would you be willing to activate fmripost-aroma on CircleCI? |
Unfortunately, we need to hear back about a no-cost extension before committing more money to CircleCI. Would you be willing to run it on your fork? |
I can do that, although I'm not sure how the Docker deployment would work. |
I can just have my fork deploy I guess. I am worried about deploying from tags, but I can just push to |
For docker, we could deploy via GitHub actions. |
That works for me. Can you either add me to the nipreps org on DockerHub (username tsalo) or add your credentials as secrets on this repo? The action I'm adding in #46 needs DOCKER_USERNAME and DOCKER_PASSWORD. |
@@ -207,6 +207,15 @@ def init_single_subject_wf(subject_id: str): | |||
# Patch standard-space BOLD files into 'bold' key | |||
subject_data['bold'] = listify(subject_data['bold_mni152nlin6asym']) | |||
|
|||
if not subject_data['bold_mni152nlin6asym']: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this was a mistake for raw+derivatives processing, because the derivatives datasets weren't being queried.
Closes #42.
Pending issues:
Changes proposed in this pull request
config.execution.fmripost_aroma_dir
and just useconfig.execution.output_dir
.