Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: reduce setOptions function call #805

Merged
merged 2 commits into from
Apr 21, 2024
Merged

refactor: reduce setOptions function call #805

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7772416
refactor: reduce setOptions function call
ninoseki Apr 21, 2024
c30279b
fix: fix lint issue
ninoseki Apr 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
189 changes: 86 additions & 103 deletions src/options/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,13 @@
<script lang="ts">
<script>
export default {
name: "IndexView",
};
</script>

<script setup lang="ts">
import "bulma/css/bulma.css";

import { defineComponent, onMounted, reactive, ref, watch } from "vue";
import { onMounted, reactive, ref, watch } from "vue";

import { Scanners } from "../scanner";
import type { OptionsType, SearchableType } from "../schemas";
Expand All @@ -11,119 +17,96 @@ import type { ScannableType, Scanner, Searcher } from "../types";
import { SCANNABLE_TYPES, SEARCHABLE_TYPES } from "../types";
import { getFaviconURL } from "../utils";

export default defineComponent({
name: "OptionsView",
setup() {
const isInitialized = ref(false);
const synchedAt = ref<string>();

const searchableType = ref<SearchableType | undefined>(undefined);
const scannableType = ref<ScannableType | undefined>(undefined);
const isInitialized = ref(false);
const synchedAt = ref<string>();

const options = reactive<OptionsType>({
debug: false,
href: true,
punycode: false,
refang: true,
strict: true,
hybridAnalysisAPIKey: undefined,
urlscanAPIKey: undefined,
virusTotalAPIKey: undefined,
disabledScannerNames: [],
disabledSearcherNames: [],
});
const searchableType = ref<SearchableType | undefined>(undefined);
const scannableType = ref<ScannableType | undefined>(undefined);

onMounted(async () => {
const storageOptions = await getOptions();
Object.assign(options, { ...storageOptions });
const options = reactive<OptionsType>({
debug: false,
href: true,
punycode: false,
refang: true,
strict: true,
hybridAnalysisAPIKey: undefined,
urlscanAPIKey: undefined,
virusTotalAPIKey: undefined,
disabledScannerNames: [],
disabledSearcherNames: [],
});

isInitialized.value = true;
});
onMounted(async () => {
const storageOptions = await getOptions();
Object.assign(options, { ...storageOptions });
});

const isEnabledSearcher = (name: string): boolean => {
return !options.disabledSearcherNames.includes(name);
};
const isEnabledSearcher = (name: string): boolean => {
return !options.disabledSearcherNames.includes(name);
};

const isEnabledScanner = (name: string): boolean => {
return !options.disabledScannerNames.includes(name);
};
const isEnabledScanner = (name: string): boolean => {
return !options.disabledScannerNames.includes(name);
};

const disableOrEnableSearcher = (name: string): void => {
if (options.disabledSearcherNames.includes(name)) {
options.disabledSearcherNames = options.disabledSearcherNames.filter(
(n) => n !== name,
);
} else {
options.disabledSearcherNames.push(name);
}
};
const disableOrEnableSearcher = (name: string): void => {
if (options.disabledSearcherNames.includes(name)) {
options.disabledSearcherNames = options.disabledSearcherNames.filter(
(n) => n !== name,
);
} else {
options.disabledSearcherNames.push(name);
}
};

const disableOrEnableScanner = (name: string): void => {
if (options.disabledScannerNames.includes(name)) {
options.disabledScannerNames = options.disabledScannerNames.filter(
(n) => n !== name,
);
} else {
options.disabledScannerNames.push(name);
}
};
const disableOrEnableScanner = (name: string): void => {
if (options.disabledScannerNames.includes(name)) {
options.disabledScannerNames = options.disabledScannerNames.filter(
(n) => n !== name,
);
} else {
options.disabledScannerNames.push(name);
}
};

const selectSearchableType = (selected: SearchableType): void => {
if (selected === searchableType.value) {
searchableType.value = undefined;
} else {
searchableType.value = selected;
}
};
const selectSearchableType = (selected: SearchableType): void => {
if (selected === searchableType.value) {
searchableType.value = undefined;
} else {
searchableType.value = selected;
}
};

const selectScannableType = (selected: ScannableType): void => {
if (selected === scannableType.value) {
scannableType.value = undefined;
} else {
scannableType.value = selected;
}
};
const selectScannableType = (selected: ScannableType): void => {
if (selected === scannableType.value) {
scannableType.value = undefined;
} else {
scannableType.value = selected;
}
};

const isSelectedSearcher = (searcher: Searcher): boolean => {
if (searchableType.value) {
return searcher.supportedTypes.includes(searchableType.value);
}
return true;
};
const isSelectedSearcher = (searcher: Searcher): boolean => {
if (searchableType.value) {
return searcher.supportedTypes.includes(searchableType.value);
}
return true;
};

const isSelectedScanner = (scanner: Scanner): boolean => {
if (scannableType.value) {
return scanner.supportedTypes.includes(scannableType.value);
}
return true;
};
const isSelectedScanner = (scanner: Scanner): boolean => {
if (scannableType.value) {
return scanner.supportedTypes.includes(scannableType.value);
}
return true;
};

watch(options, async () => {
await setOptions(options);
synchedAt.value = new Date().toISOString();
});
watch(options, async (newOptions) => {
// don't sync for the first time (this event is invoked through onMounted)
if (isInitialized.value) {
await setOptions(newOptions);
}

return {
options,
isInitialized,
SCANNABLE_TYPES,
scannableType,
Scanners,
SEARCHABLE_TYPES,
searchableType,
Searchers,
disableOrEnableScanner,
disableOrEnableSearcher,
getFaviconURL,
isEnabledScanner,
isEnabledSearcher,
isSelectedScanner,
isSelectedSearcher,
selectScannableType,
selectSearchableType,
synchedAt,
};
},
synchedAt.value = new Date().toISOString();
isInitialized.value = true;
});
</script>

Expand All @@ -141,7 +124,7 @@ export default defineComponent({
<a class="navbar-item" href="#searchers"> Searchers </a>
</div>
<div class="navbar-end">
<span class="navbar-item help" v-if="synchedAt">
<span class="navbar-item" v-if="synchedAt">
(Synced at: {{ synchedAt }})
</span>
</div>
Expand Down
Loading